Allow for larger range for universal offset setting#58
Open
lightyisreal wants to merge 1 commit intoppy:masterfrom
Open
Allow for larger range for universal offset setting#58lightyisreal wants to merge 1 commit intoppy:masterfrom
lightyisreal wants to merge 1 commit intoppy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue #50, I increased the universal offset setting range to 300 ms. I can decrease it to 200 ms if you want it. The problem with the universal offset being that high is that samples/hitsounds sound really delayed while playing due to them being delayed as well using the universal offset.
One note: I may have messed up some configs, but everything should work as usual. Hopefully, that's not a problem